search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
775 stars 327 forks source link

Add license page #687

Closed rkonno closed 4 years ago

rkonno commented 4 years ago

Issue

Overview (Required)

Links

Screenshot

Before After
rkonno commented 4 years ago

At present, there is a problem that all dependent libraries are not enumerated. I'm investigating this issue now.

I'd really appreciate it if you could give me your opinion.

takahirom commented 4 years ago

At present, there is a problem that all dependent libraries are not enumerated. I'm investigating this issue now. I'd really appreciate it if you could give me your opinion.

This app is open source. So it doesn't matter if you can't enumerate. I think it is good to merge and create an issue.

koji-1009 commented 4 years ago

Hi, the issue looks like to be related to the following issues.

https://github.com/google/play-services-plugins/issues/7 https://github.com/google/play-services-plugins/issues/25

I am facing the same problem (in another project!), and want to know how to solve it!

takahirom commented 4 years ago

Looks good! How about remove WIP? And can you solve conflict? 🙇

rkonno commented 4 years ago

@takahirom Thanks! Resolved conflict and removed WIP.

rkonno commented 4 years ago

@koji-1009 Thanks for sharing information related to the plugin issue! I also created a new issue to solve this problem. (#713)

takahirom commented 4 years ago

On CI đź‘€ Can you check it?

Execution failed for task ':android-base:generateLicenses'.
> Ambiguous method overloading for method com.google.android.gms.oss.licenses.plugin.LicensesTask_Decorated#addLicensesFromPom.
  Cannot resolve which method to invoke for [null, class java.lang.String, class java.lang.String] due to overlapping prototypes between:
    [class java.io.File, class java.lang.String, class java.lang.String]
    [class java.lang.String, class java.lang.String, class java.lang.String]
jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/7fae15f61fadfdd2a4232f81206d9d6bb21eee5c. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago
1 Warning
:warning: corecomponent/androidcomponent/src/main/res/values-ja/strings.xml#L6 - The resource string “material_label” has been marked as translatable=”false” elsewhere (usually in the values folder), but is translated to “ja” (Japanese) here

No error was reported but at least one warning was found.

Generated by :no_entry_sign: Danger