Fix ios event tab - Githubissues

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo

https://droidkaigi.jp/2020/en/

Apache License 2.0

775 stars 327 forks source link

Fix ios event tab #708

Closed clockvoid closed 4 years ago

clockvoid commented 4 years ago

Issue

close #657

Overview (Required)

Delete EventViewController
- In PR #696, I created EventViewController because I thought the events are not sessions. However, while reading the Android side source code, I noticed the events are obtained by the same endpoint as all sessions. So, I delete it and Implement the event tab by using if statement.
- Please advise me which is the best solution.
Implement filters for the event tab and the myplan tab.

Screenshot

Temporary, I use pictures filtered by backdrop instead of exhibition. Because, for now, there are sessions that are typed exhibition.

Before	After

ry-itto commented 4 years ago

@clockvoid

Temporary, I use pictures filtered by backdrop instead of exhibition. Because, for now, there are sessions that are typed exhibition.

This means session which has exhibition type is none?

clockvoid commented 4 years ago

@ry-itto Thank you for your reviewing. Yes. For now, there is no session that is typed exhibition. You can verify it by searching time table response.

clockvoid commented 4 years ago

@ry-itto Thank you for reviewing. I fixed it.

ry-itto commented 4 years ago

LGTM 😄 I will merge this 👍

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/be56cd1a77fd071411a7a6f7a7df962fd49d677e. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger

DroidKaigi / conference-app-2020

Fix ios event tab #708

Issue

Overview (Required)

Links

696

Screenshot