Closed clockvoid closed 4 years ago
Probably we should implement level filter🙏
@takahirom Thank you for your replying. I want to implement it. I will implement it like 2019 version app to pass the FiltersTest.
Thanks! Assigned!🙏
I think we should have list. Not forBeginer field. forBeginnerのようなフィールドではなく、レベルをリストで持ってるような構造にする必要がありそうです🙏
I see. We can see the list of level in timetable response. In this response, the level Array has three elements, but the app's filter has two. What is the third element? すみません、日本語で失礼します。 レスポンスを見るとリストで持っていますね... 3つ要素があるようですが、アプリのフィルターは2つしか持ってないです。これ3つめは何なんですかね...?
初心者向け、中級者、上級者だった気がします🙏
理解です。 多分これアプリ側のフィルターとしても全部必要かと思いますので、そこも含めてやっちゃいます
あってます。ありがとうございます😂
Overview (Required) I think FiltersTest does not pass correctly. Because the data class Session has no member "forBeginners" but the test checks this parameter. Additionally, data class has the member "intendedAudience", but the actual response doesn't have that. SessionEntity's intendedAudience value is always null. And also, the Filters#isPass() method does not check audience categories. I think this app's audience filter function is not working. Both in day1 and day2, the results are the same with or without the level filters.
Steps To Reproduce
Expected behavior Filter sessions by audience categories.
Screenshots
Env:
Additional context I found this problem when researching #614 . But this issue is more deep-seated than I thought, so I divided.