search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 328 forks source link

Add SessionListTest #720

Closed shiraji closed 4 years ago

shiraji commented 4 years ago

Issue

Overview (Required)

Links

N/A

Screenshot

N/A

takahirom commented 4 years ago

Thank you as always!
This time it's okay because it doesn't run on Android, but I avoided using white space in method names because Android doesn't support spaces.
What do you think? https://discuss.kotlinlang.org/t/android-issue-with-backticked-method-names/66

shiraji commented 4 years ago

how about replacing spaces with _ ?

takahirom commented 4 years ago

I also like spaces, but please replace them with underbars this time.🙏

shiraji commented 4 years ago

sure!

shiraji commented 4 years ago

Fixed them and squash commits.

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/8267dd4377668adf642ffe942934b686e8ea3d23. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger

takahirom commented 4 years ago

LGTM! Thank you for contribution!🙏