search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 328 forks source link

[iOS] fix: Show livebadge only on live #724

Closed KaoruMuta closed 4 years ago

KaoruMuta commented 4 years ago

Issue

Overview (Required)

I just judge whether the talk session is on live or not by the value of session.isOnGoing.

Links

-

ry-itto commented 4 years ago

@KaoruMuta This PR can review now?

KaoruMuta commented 4 years ago

@ry-itto Sorry for late reply. It seemed that it was conflicted, and I resolved the conflict.

So, this PR can be reviewed now.

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/48eaac121a32f1132e244aea7907424f95d90013. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger

KaoruMuta commented 4 years ago

I'm relieved, thanks! And please close issue #704 if you have time!

KaoruMuta commented 4 years ago

Sorry, I find a really minor problem in my scripts.

As usual, the indentation is a tab, but in case it's a space.

Do you think it should be resolved? If you agree, I'm going to resolve.

ry-itto commented 4 years ago

I'm sorry... I missed. Please fix it 🙏