search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
775 stars 327 forks source link

Fetch floor map image from server instead #726

Closed kuramu1108 closed 4 years ago

kuramu1108 commented 4 years ago

Issue

Overview (Required)

kuramu1108 commented 4 years ago

I would like to be advised a better placeholder image from the designer(?) maybe

takahirom commented 4 years ago

The new map image is available now on Figma! (CC: @ry-itto ) Can you use it for a placeholder? (Server-side image is still needed)

takahirom commented 4 years ago

probably ./gradlew :feature:floormap:ktlint become error 👀

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/92182032a2449dbe7e094b11aa379c55d37579d1. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No error was reported but at least one warning was found.

Generated by :no_entry_sign: Danger

kuramu1108 commented 4 years ago

@takahirom thanks, got time to fix it just now 🙇‍♂️

takahirom commented 4 years ago

Thanks! LGTM!!