search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
775 stars 327 forks source link

Fix a bug that the BottomAppBar is not close to the FAB #741

Closed yurihondo closed 4 years ago

yurihondo commented 4 years ago

Issue

Overview (Required)

The cause of this issue is that the BottomAppBar cannot calculate its height correctly in API level 21 environment. So I added process to measure own size when #doOnNextLayout is called.

Links

Screenshot

Before After
Nexus5 Android5.0
yurihondo commented 4 years ago

@takahirom Could you please check this PR when you have time? Thanks.

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/a1ec0670bf22e69ac9aaab0755c51a5542055b4b. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger

takahirom commented 4 years ago

Thanks!!! Awesome!!!!!