search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
773 stars 328 forks source link

[iOS] Probably not passed CONFIGURATION to Gradle #747

Closed takahirom closed 4 years ago

takahirom commented 4 years ago

Kind (Required)

takahirom commented 4 years ago

We want to use it here https://github.com/droidkaigi/conference-app-2020/blob/master/ios-combined/build.gradle#L70

ry-itto commented 4 years ago

I think the property is passed to Gradle. I tried it to put a code println mode to next line of ios-combined/build.gradle L70. Like this.

final String mode = project.findProperty("XCODE_CONFIGURATION")?.toUpperCase() ?: 'DEBUG'
println mode

And This is executing result.

> BUILD_IOS=true ./gradlew ios-combined:linkIosX64 -PXCODE_CONFIGURATION=Release
> Configure project :android-base
WARNING:
....
> Configure project :ios-combined
Kotlin Multiplatform Projects are an experimental feature.
RELEASE
<-------------> 0% EXECUTING [7s]

The way of confirming above is correct, I think it passed.

I think this option is probably passing property to gradle. -PXCODE_CONFIGURATION=${CONFIGURATION} And in Xcode, CONFIGURATION property represents a build mode such as Debug or Release.

Please tell me if I misunderstood about this 🙏

takahirom commented 4 years ago

Thanks! I can not switch develop API and production API. Can you do it? production api has event sessions!

takahirom commented 4 years ago

When I confirm event session. I rewrite url😂

ry-itto commented 4 years ago

I see! I will try it 😄

ry-itto commented 4 years ago

I'm sorry I can't confirm showing event sessions... Can I tell how to show that? 🙏

I tried following in scripts/build_kotlin_modules.sh

 BUILD_IOS=true ./gradlew :ios-combined:$KN_LIBRARY_BUILD_TASK -PXCODE_CONFIGURATION=Production
takahirom commented 4 years ago

I changed this API endpoint to http://api.droidkaigi.jp/2020 https://github.com/droidkaigi/conference-app-2020/blob/master/data/api/src/iosMain/kotlinDebug/io/github/droidkaigi/confsched2020/data/api/internal/apiEndpoint.kt#L4 FYR you can check timetable http://deploy-preview-49--droidkaigi-api-dev.netlify.com/2020/timetable https://api.droidkaigi.jp/2020/timetable/

takahirom commented 4 years ago

Probably you should use RELEASE instead of Production https://github.com/droidkaigi/conference-app-2020/blob/master/ios-combined/build.gradle#L73

ry-itto commented 4 years ago

I understand. I will try with Release. 👍

ry-itto commented 4 years ago

Thanks! I confirmed 🙏 I may miss some point...

ry-itto commented 4 years ago

Please try this with https://github.com/DroidKaigi/conference-app-2020/pull/753 ? 🙏