search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
773 stars 328 forks source link

Fix a bug that the session title is not translated #771

Closed yurihondo closed 4 years ago

yurihondo commented 4 years ago

Issue

none

Overview (Required)

Fixed a bug that the session title was not translated even if set english lang to device.

Links

none

Screenshot

Before After
takahirom commented 4 years ago

Can we use this?? 👀 https://github.com/DroidKaigi/conference-app-2020/blob/master/model/src/commonMain/kotlin/io/github/droidkaigi/confsched2020/model/LocaledString.kt#L8

yurihondo commented 4 years ago

Oh...Thank you for your advice. I'll modify it.

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/15ebb4116551302aa0264d81dd6c145e3980387f. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger