DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
773 stars 328 forks source link

[iOS]Cache images when loading floor map #775

Closed tomu28 closed 4 years ago

tomu28 commented 4 years ago

Issue

Overview (Required)

Links

Screenshot

No UI changes.

Before After
ry-itto commented 4 years ago

How can I confirm images are cached? If you know, please tell me. 🙏

tomu28 commented 4 years ago

Thank you for the review😄 I will fix it once confirmed!

tomu28 commented 4 years ago

@ry-itto

How can I confirm images are cached? If you know, please tell me. 🙏

Oh, sorry! The explanation was insufficient🙇‍♂️

You can check that the image is cached by following the steps below! Thank you for your help in advance.😄

Step1:

Until the image from the server is loaded, the default map image specified in Storyboard is displayed. So, change the set image(map.png) to make it easier to confirm that the image is loaded from the server.

Reference image:

This time, I changed from map to header_about.

refarenceImage

Step2:

When successfully loaded, showing cached images. Please run and check🙏 At first, header_about is displayed, but it will switch when the image is loaded.

Step3:

  1. For 120 seconds, the floor map image is cached.(ImageCache.shared [request] contains image data as cache) So, open another screen such as the timeline once.
  2. Open the floor map again.
  3. If there is an image already cached, display that image. At that time, you can see that ImagePipeline.shared.loadImage is not called.

If you use breakpoint or Step Over, it will be easier to confirm. In this part!

Finally, If there is anything I can help you with, please do not hesitate to reply me!

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/940d3e5dc6a3ea608214b707f00009ee04d096a1. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger