search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
775 stars 327 forks source link

Search sessions or speakers by voice-search #776

Closed imsakuu closed 4 years ago

imsakuu commented 4 years ago

Issue

Overview (Required)

-Apply voice input to SearchView -Don't apply design about mic-icon #437

Links

-https://developer.android.com/reference/android/widget/SearchView -https://developer.android.com/guide/topics/search/search-dialog.html -https://developer.android.com/guide/topics/search/searchable-config.html

Screenshot

Before After
takahirom commented 4 years ago

Thanks! I merged this PR Can you check after merge master? 🙇 https://github.com/DroidKaigi/conference-app-2020/pull/781

imsakuu commented 4 years ago

@takahirom Sure. I'll do it! btw, which should I use "merge" or "rebase" just in case? Sorry to a basic question.🙇‍♂️

takahirom commented 4 years ago

I think both rebase and merge have good points, so I'm not particular about the policy. Please do it any way you like. 😄

takahirom commented 4 years ago

Sorry please wait this https://github.com/DroidKaigi/conference-app-2020/pull/787

takahirom commented 4 years ago

I merged it 🙇

imsakuu commented 4 years ago

I think both rebase and merge have good points, so I'm not particular about the policy. Please do it any way you like. 😄

That's right. Thanks for answer.😳

imsakuu commented 4 years ago

I think no problem between #781 and mine. However, I have no confidence about my code💦

takahirom commented 4 years ago

When we use light theme. we can not see voice icon 😭

imsakuu commented 4 years ago

Yes. i knew it 😂 I tried to apply voice icon design. But I stopped it and deleted codes when I noticed #437 ...💦

imsakuu commented 4 years ago

I can try again about voice icon if you can wait🙇‍♂️

takahirom commented 4 years ago

I can try again about voice icon if you can wait🙇‍♂

Yes! You can this in 1.2 or later 👍

takahirom commented 4 years ago

I pushed a little refactoring!

imsakuu commented 4 years ago

I pushed a little refactoring!

I have many things to learn from this refactoring 👀 Thanks!😊

imsakuu commented 4 years ago

I pushed about voice icon changes! But icon color is different from the design 😢 figma

Light Dark
takahirom commented 4 years ago

Can you check this? ./gradlew :feature:session:ktlint

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/76f0306b29d4cd5fb9c4c4c6afee4f48bc27b78e. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago
1 Warning
:warning: android-base/src/main/AndroidManifest.xml#L5 - On SDK version 23 and up, your app data will be automatically backed up, and restored on app install. Your GCM regid will not work across restores, so you must ensure that it is excluded from the back-up set. Use the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html

No error was reported but at least one warning was found.

Generated by :no_entry_sign: Danger

imsakuu commented 4 years ago

Can you check this? ./gradlew :feature:session:ktlint

I fixed 🙏

takahirom commented 4 years ago

Thanks! LGTM 👍

imsakuu commented 4 years ago

Thanks for so kind reviews 😭 It helps me a lot 🙇‍♂️