#785 Fix to use https connection

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo

https://droidkaigi.jp/2020/en/

Apache License 2.0

775 stars 327 forks source link

#785 Fix to use https connection #802

Closed emusute1212 closed 4 years ago

emusute1212 commented 4 years ago

Issue

close #785

Overview (Required)

API_ENDPOINT change scheme from http to https
adding last / to timetable api URL.
delete usesCleartextTraffic

Others

marge target branch is master ok?

takahirom commented 4 years ago

Probably we should fix announcement and other apis 🙇

jmatsu-bot commented 4 years ago

1 Warning

:warning: android-base/src/main/AndroidManifest.xml#L5 - On SDK version 23 and up, your app data will be automatically backed up, and restored on app install. Your GCM regid will not work across restores, so you must ensure that it is excluded from the back-up set. Use the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html

	1 Warning
:warning:	android-base/src/main/AndroidManifest.xml#L5 - On SDK version 23 and up, your app data will be automatically backed up, and restored on app install. Your GCM regid will not work across restores, so you must ensure that it is excluded from the back-up set. Use the attribute `android:fullBackupContent` to specify an `@xml` resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html

No error was reported but at least one warning was found.

Generated by :no_entry_sign: Danger

emusute1212 commented 4 years ago

@takahirom fixed 🙇
572281c28c60e684618a2db26c217b45753543c7

And, changed iosMain url scheme from http to https. 👀

ef4d5dfb0cb62814b0db7f173af59ea798fa79c8

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/2d93dfc79af8f327b41aa39727a54cfb311fffdc. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

takahirom commented 4 years ago

LGTM 👍