search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 328 forks source link

Suppress const modifier lint warning on Dep.kt #806

Closed chibatching closed 4 years ago

chibatching commented 4 years ago

Issue

Overview (Required)

Links

Screenshot

Before After
takahirom commented 4 years ago

Because it is simple, I prefer to suppress without const, but is it better to do so? 👀 (performance?)

chibatching commented 4 years ago

Yes, it has just a bit performance advantage. If you prefer to suppress warning, I'd revert the code and change suppress warning.

chibatching commented 4 years ago

Hi, I changed the way to remove warnings. I added suppress rule MayBeConstant to Dep.kt, and organize commit by rebasing.

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/02565b273e6f2376e1f7aa381d52f1260ca8710c. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger

takahirom commented 4 years ago

Thanks! LGTM 🙏