search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
775 stars 327 forks source link

[iOS] Cache speaker icon's image #807

Closed tomu28 closed 4 years ago

tomu28 commented 4 years ago

Issue

Overview (Required)

Links

Screenshot

No UI changes.

Before After
tomu28 commented 4 years ago

You can check that the speaker icon's image is cached by following the steps below! Thank you for your help in advance.😄

  1. Run the app and display the timeline page.
  2. Switch to other pages such as announcements and floor map.
  3. Finally, switch to the timeline page within the cache storage time of 120 seconds.

Then, speaker Icon's cached can confirm that ImagePipeline.shared.loadImage is displayed without being called.

If you use breakpoint or Step Over, it will be easier to confirm. In this part!

tomu28 commented 4 years ago

@ry-itto Improved! Could you please check when you have time🙇‍♂️

tomu28 commented 4 years ago

@ry-itto Thank you for checking😊 Fixed related section!

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/cb3095217396d94eaaed7fb87cdd301df8257be2. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger