DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
775 stars 327 forks source link

WTF !! lost library & di error !! #828

Closed CMingTseng closed 3 years ago

CMingTseng commented 3 years ago

Dear Sir

very thanks the codelab-2020

https://droidkaigi.github.io/codelab-2020/en/index.html#0

but the demo code https://github.com/DroidKaigi/architecture-components-samples.git

(branch : droidkaigi-2020-codelab & droidkaigi-2020-codelab-modularized )

lost something !!

@ versions.gradle

  1. lifecycle.runtime_ktx --> app & feature:login

  2. kotpref_initializer & kotpref_core --> data:repository

  3. deps.browser --> feature:login

can not di !!!

LoginActivity @feature:login get error

it show

Can not access 'android.lifecycle.HasDefaultViewModelProviderFactory' which is supertype of 'com.android.example.feature.login.LoginActivity'.Check your module classpath for missing or conflicting dependencies

THX

takahirom commented 3 years ago

Thank you for reporting! I'll contact the creator of codelab-2020.

tomoya0x00 commented 3 years ago

πŸ‘€

tomoya0x00 commented 3 years ago

@CMingTseng Hi!

Can you check that you opened the GithubBrowserSample project?

γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2021-01-06 1 12 33

On my Mac, both branches were built successfully with Android Studio 4.1.1.

Thanks!

CMingTseng commented 3 years ago

@CMingTseng Hi!

Can you check that you opened the GithubBrowserSample project?

γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2021-01-06 1 12 33

On my Mac, both branches were built successfully with Android Studio 4.1.1.

Thanks!

Dear Sir

THX

now i know why !!

the demo project has over two versions.gradle

first i clone it , and then modify structure project (like add setting.gradle at rootpath ...balabala )

the outside versions.gradle is different versions.gradle at GithubBrowserSample (something is different )

so l lost dependencies library

but some sub_project can not standalone build as library aar file

THX