search

DroidKaigi / conference-app-2021

The Official App for DroidKaigi 2021
https://droidkaigi.jp/
Apache License 2.0
641 stars 181 forks source link

Proposal about the design for the iOS app #334

Closed myihsan closed 3 years ago

myihsan commented 3 years ago

Kind (Required)

Proposal / Discussion

Overview (Required)

Is there any chance that we can have another design for the iOS app?

We can indeed use material-components-ios, but we cannot use it directly since it's implemented by UIKit which is different from our current layout framework–SwiftUI. It's possible to make it work in SwiftUI, but it will take many unnecessary efforts and face unexpected issues.

So I think it may be a good idea to have another design for iOS. It's not only for the development cost but also for the iOS users.

If it's possible, I would like to try to invite a designer to help us. It would be helpful to have the information below:

takahirom commented 3 years ago

Thank you for your suggestion. I'll talk with the staff. 🙏

takahirom commented 3 years ago

I'm sorry to be late. I will report on the current situation for the time being. I talked to the designer who designed Android for the time being, but it seems that it will take time to prepare the design, so it seems that it is not realistic to prepare the iOS design. She's also new to figma and wants to see the designs of other designers. Therefore, it may be better to recruit designers at present. Currently, I didn't expect them, so I don't have those documents. Perhaps it is better to share what you want to hear at Meeting etc. with external designers, including designers who designed Android applications and engineers who understand iOS development.

myihsan commented 3 years ago

Thanks! Let me ask designers in my company if they have interests. Just to confirm, there is no reward for the design, right? I am not sure if this is normal in the designer world, so I will point it out while asking them.

takahirom commented 3 years ago

I'm sorry, there is no reward. I don't know if it's a reward, but I can only put the designer's name in the README. https://github.com/DroidKaigi/conference-app-2021#designer

myihsan commented 3 years ago

The inviting is ongoing. Once there is one designer who raises his/her hand, let's schedule a meeting.

However, I found out that attending the meeting without some base information is already a hurdle for participation. So it would be very helpful for the designers who have interests but not sure if they have enough time to answer the questions below as possible before the meeting.

Especially the first two, I think.

takahirom commented 3 years ago

Thank you. I'll prepare it with the designer. 🙏

takahirom commented 3 years ago

I talked to the designer about this.

Work Period (deadline) It hasn't been decided in particular, but it seems that contributors will easily gather within a month.

Function list https://www.figma.com/file/IFlrbfmBSdYvUz7VmSzfLV/DroidKaigi_2021_official_app You can check the feed You can check about this app You can check the contributors You can check the staff You can check the settings You can see the recruitment of questionnaires

With or without a regular meeting There are no regular meetings, and they meet online if they need something. Recently, about once a month.

Universal Design guideline (is there anything that should not change from the Android design) I don't think it has to be perfectly aligned, but We are interested in Color and Shape. Other than that, it has not been decided.

Color is shown in Figma (* Layer names are different ...) https://www.figma.com/file/IFlrbfmBSdYvUz7VmSzfLV/DroidKaigi_2021_official_app?node-id=1072%3A420 The dark theme has not been designed, and the contributors make it on their own.

Shape top left and bottom right corner cut large component 32 small, medium 8

If you can make the design a designer, that's fine, but if you tell the Android designer the points to focus on iOS design, it will take time, but it seems that the designer who designed Android may be able to design it. If saying this is likely to cause confusion, don't worry.

Work Period (deadline) 特に決まっていないが1ヶ月以内ぐらいだとコントリビューターが集まりやすそう

Function list https://www.figma.com/file/IFlrbfmBSdYvUz7VmSzfLV/DroidKaigi_2021_official_app フィードを確認できる このアプリについて確認できる コントリビューターを確認できる スタッフが確認できる 設定を確認できる アンケートの募集が見られる

With or without a regular meeting 定例会議はなく、何か必要になれば集まっている。月一程度あるかないか。

Universal Design guideline (is there anything that should not change from the Android design) 完璧に揃えなくてはいけないと思ってはいないが、関心事としてColorとShapeがある。それ以外は決まっていない。

https://www.figma.com/file/IFlrbfmBSdYvUz7VmSzfLV/DroidKaigi_2021_official_app?node-id=1072%3A420 ColorはFigmaにある（※レイヤーの名前がバラバラになっている… ダークテーマについてはデザインはできておらず、コントリビューターが作っている。

Shape top left and bottom right corner cut large component 32 small, medium 8

もしデザインをデザイナーにしていただけるならそれで良いが、iOSのデザインに寄せるポイントを教えていただければ、時間はかかるがAndroidのデザインをしたデザイナーがデザインすることもできるかもしれないそうです。 もしこれを言うことで混乱を招きそうであれば言わなくても大丈夫です。

myihsan commented 3 years ago

Thanks a lot! Let me share with the designers.

もしデザインをデザイナーにしていただけるならそれで良いが、iOSのデザインに寄せるポイントを教えていただければ、時間はかかるがAndroidのデザインをしたデザイナーがデザインすることもできるかもしれないそうです。

なるほど、もしこちらに余裕かつ興味があるデザイナーがいなければ、ぜひこちらの協力をさせていただきたいです🙇‍♂️

myihsan commented 3 years ago

Here is one designer who raises her hand! Her current situation is as below:

Is it ok for you guys?

takahirom commented 3 years ago

Thank you! It's okay.

myihsan commented 3 years ago

Thanks for the chance! This would be a significant improvement for the iOS development, which would attract more iOS engineers who have interests in KMM and SwiftUI.

I will contact you as soon as there is any update from the designer.

myihsan commented 3 years ago

FYI, the designer is going to start the design this weekend.

takahirom commented 3 years ago

Thank you! 🎉 I'd like to ask if it's better to do something like onboarding MTG or ask a text-based question what you want to know. 👀

myihsan commented 3 years ago

It seems like the information here https://github.com/DroidKaigi/conference-app-2021/issues/334#issuecomment-800724327 is enough for now. Is there any news?

The design will share the intermediate design once she is ready.

takahirom commented 3 years ago

Thank you! There are no other changes. If you have any, please tell me anytime. 🙏

myihsan commented 3 years ago

Here is one quick question.

Will there a native detail page for the feed? This may affect the design.

takahirom commented 3 years ago

The detail page does not exist. On Android, it is displayed on the Web using Chrome Custom Tab. I think it will probably be Safari View Controller on iOS.

nobonobopurin-zz commented 3 years ago

Hello, I'm Choi, a designer. I am happy to participate in this project as a designer. The UI for the iOS app is complete, so now it can be shared.

Link : DroidKaigi_2021_official_App (iOS)

The colors and shapes have been adapted to Android UI, but the major changes are as follows.

Is it ok for you guys?

takahirom commented 3 years ago

Thank you! I'll check! @myihsan Please comment if you have any advice from the perspective of an iOS engineer.

takahirom commented 3 years ago

I checked a little. I think it's easy to understand and has a very good design. It seems that the composition of the screen has changed quite a bit.

One thing I'm worried about is that it may not be possible to use common logic between iOS and Android. I'm sorry I couldn't share this issue because I couldn't anticipate it. I think I should have asked you to share it when You started making design a little. However, even if the common logic cannot be used for the UI logic, I think that the others can be used, and I think it is better to proceed for the time being. 👍

myihsan commented 3 years ago

Please comment if you have any advice from the perspective of an iOS engineer.

I have done it before the sharing above. The only remaining issue is the loading screen better not cover the full screen.

I will try to ask more iOS engineers for advice next week.

One thing I'm worried about is that it may not be possible to use common logic between iOS and Android.

I think it also has a good side for practice the design for the shared KMM module.

nobonobopurin-zz commented 3 years ago

Is it okay to modify the design so that the loading screen no longer covers the full screen? I forgot to change to a Skeleton screen.

myihsan commented 3 years ago

It may not be necessary after I demonstrate the way we implement Skeleton screen by SwiftUI. So please keep your time for some new proposal or advice from other iOS engineers next week🙇‍♂️

myihsan commented 3 years ago

@takahirom The review by six iOS engineers in YUMEMI Inc., including me, has ended. The conclusion is that an iOS engineer can implement this design with SwiftUI-Introspect (A library that helps us deal with some iOS components that hard to custom in SwiftUI) without too many efforts. So this design looks good for us.

Is our review enough for you? If so, it may be time to update README so that we can close this issue.

takahirom commented 3 years ago

Thank you! I will close the issue and put it in the README. 🎉 @nobonobopurin I'd like to list it below as a designer. Is there any link you would like to use? https://github.com/DroidKaigi/conference-app-2021#designer

nobonobopurin-zz commented 3 years ago

@takahirom Thank you! 🎉 Please use the link below: https://github.com/nobonobopurin

takahirom commented 3 years ago

Thank you! I will update README 👍