Open jmatsu opened 3 years ago
takahirom
commented
3 years ago Thank you for creating the issue! I wasn't aware of the problem. Can I ask you what the problems are with running only on Linux? Perhaps this token has been improved. https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks
jmatsu
commented
3 years ago If we never choose macOS runner, then it's fine anyway. I'm thinking it's less useful as a ci/cd sample if it depends on the runner though.
It'd be okay if the action works fine with pull_request_target. I know pull_request_target can provide write permission tokens as I've already used it in other workflows, but not sure if the reviewdog action supports the trigger. It has the same payload and filters to pull_request trigger but GitHub Actions parameters like GIT_SHA differ as the blog says.
takahirom
commented
3 years ago Certainly, if you want to create a Lint flow etc. and do it there, you may be in trouble because you need a mac with Kotlin MPP. If there is another way, I would like to try it. :+1:
Separately, I think it's a good idea to try pull_request_target once and think again if it doesn't seem to work. For the time being, I will change it to pull_request_target.
takahirom
commented
3 years ago I tried it. But it does not work. https://github.com/DroidKaigi/conference-app-2021/pull/51
Currently, reviewdog doesn't seem to support forked PR. https://github.com/reviewdog/reviewdog/issues/759
reviewdog: This is Pull-Request from forked repository.
GitHub token doesn't have write permission of Review API, so reviewdog will
report results via logging command [1] and create annotations similar to
github-pr-check reporter as a fallback.
Kind (Required)
Improvement
Overview (Required)
The current workflow configuration does not work for pull requests from contributors due to a token's permission
The current reviewdog action is built on a Docker action, but only Linux can use Docker actions.
Links