Use value classes - Githubissues

DroidKaigi / conference-app-2021

The Official App for DroidKaigi 2021

https://droidkaigi.jp/

Apache License 2.0

641 stars 181 forks source link

Use value classes #731

Closed koji-1009 closed 3 years ago

koji-1009 commented 3 years ago

Issue

close #657

Overview (Required)

Introducing value classes(inline classes)
- Add FeedItemId and TimetableItemId
- Update unit test
Converting between String and Inline Class where I/O layer

Discussion

Cannot bring inline class types into Swift
- https://github.com/JetBrains/kotlin-native/issues/3032
- https://youtrack.jetbrains.com/issue/KT-32352
In reality, the primitive type (in this case, String) is given in the Swift code
- Type checking becomes necessary...

Links

Screenshot

Before	After

takahirom commented 3 years ago

👀