search

DroidKaigi / conference-app-2022

The Official Conference App for DroidKaigi 2022
https://droidkaigi.jp/2022/
Apache License 2.0
489 stars 189 forks source link

[Bugfix] Check that scroll offset is not Float.NAN before scroll #878

Closed Tomoyuki-TAKEZAKI closed 1 year ago

Tomoyuki-TAKEZAKI commented 1 year ago

Issue

Overview (Required)

The crash is Caused by creating an instance of Offset with Float.NAN, but I can't find the root cause of it. In other words, I can't find a division by 0f on the call hierarchy.

So I added an if block to prevent scroll with an invalid offset.

This does not fix the root cause, but I think this will work.

Screenshot

I can't reproduce the crash on my env, so no screen recording.