DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023
Apache License 2.0
645 stars 206 forks source link

Extract kover configurations into a build-logic plugin #1073

Closed nashcft closed 1 year ago

nashcft commented 1 year ago

Issue

Overview (Required)

Extracted kover configurations for each projects into a plugin like kotlinx.coroutines' convention plugin so that, when we add a new module, we don't have to care about applying kover plugin to it and adding kover declaration to report-aggregator module.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

N/A

Movie (Optional)

N/A

github-actions[bot] commented 1 year ago

Test Results

211 tests   211 :heavy_check_mark:  6m 26s :stopwatch:   11 suites      0 :zzz:   11 files        0 :x:

Results for commit f35f2996.

:recycle: This comment has been updated with latest results.

takahirom commented 1 year ago

Can you fix the conflict? 🙏

nashcft commented 1 year ago

Thanks for the review 🙏

Project Isolation

I've read that document and I understand this change will affect project isolation feature in current stage. But the feature is still in experimental, so I also think it should be OK that we use plugins or configurations like this for now 👍