Fixed animation issue of TimetableItemDetailScreenTopAppBar

DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023

Apache License 2.0

645 stars 206 forks source link

Fixed animation issue of TimetableItemDetailScreenTopAppBar #1081

Closed tepi0820 closed 1 year ago

tepi0820 commented 1 year ago

Issue

close #372

Overview (Required)

The animation of the timetable detail's top app bar is a little weird, so this fix will make the animation smoother.
I have tested out first six sessions' titles to check the behavior. Since max lines of the headline is two, I thought it would be enough if I check cases where the headlines are one or two, but if I should have checked another cases please let me know.

Movie (Optional)

Before	After

github-actions[bot] commented 1 year ago

Hi @tepi0820! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

github-actions[bot] commented 1 year ago

Snapshot diff report	File name	Image
TimetableItemDetailS creenTest.checkLaunc hAccessibilityShot_c ompare.png

github-actions[bot] commented 1 year ago

Test Results

209 tests 209 :heavy_check_mark: 6m 54s :stopwatch:   11 suites     0 :zzz:   11 files     0 :x:

Results for commit 4a42939e.

:recycle: This comment has been updated with latest results.

tepi0820 commented 1 year ago

Sorry, I ran ./gradlew detekt --auto-correct and fixed the issue detected by GitHub Action. f91ee7f