enable back at contributors - Githubissues

DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023

Apache License 2.0

645 stars 206 forks source link

enable back at contributors #1086

Closed furusin closed 1 year ago

furusin commented 1 year ago

Issue

there is no Issue about this PR. I just found the difference.

Overview (Required)

made enable to back with navigation icon at contributors view
- took the same solution as StaffScreen
- https://github.com/DroidKaigi/conference-app-2023/blob/main/feature/staff/src/main/kotlin/io/github/droidkaigi/confsched2023/staff/StaffScreen.kt#L88

Links

design: https://www.figma.com/file/MbElhCEnjqnuodmvwabh9K/DroidKaigi-2023-App-UI?type=design&node-id=55032-59308&mode=design&t=BaA1ZwkaNk0QwP3n-4

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before	After

Movie (Optional)

Before	After

github-actions[bot] commented 1 year ago

Test Results

215 tests 215 :heavy_check_mark: 7m 5s :stopwatch:   11 suites     0 :zzz:   11 files     0 :x:

Results for commit 027d785e.

:recycle: This comment has been updated with latest results.

takahirom commented 1 year ago

Looks great! Thanks

furusin commented 1 year ago

@takahirom Thank you for your check! Please merge whenever you can.