DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023
Apache License 2.0
645 stars 206 forks source link

[Android]Enabled scroll functionality during zoom actions. #1103

Closed syam4869 closed 1 year ago

syam4869 commented 1 year ago

Issue

Overview (Required)

I have made adjustments to allow the zoom and scroll functionalities in the timetable grid view to operate simultaneously. Inside the .transformable modifier, I modified the rememberTransformableState callback function. This should allow for the appropriate updating of the vertical scale value using the zoomChange parameter while zoom actions are being conducted.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After
---
github-actions[bot] commented 1 year ago

Hi @syam4869! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

github-actions[bot] commented 1 year ago
Snapshot diff report File name Image
TimetableScreenTest.
checkGridScrollShot_
compare.png
github-actions[bot] commented 1 year ago

Test Results

215 tests   215 :heavy_check_mark:  6m 50s :stopwatch:   11 suites      0 :zzz:   11 files        0 :x:

Results for commit b1a54146.

:recycle: This comment has been updated with latest results.

syam4869 commented 1 year ago

@mhidaka Why is CI built on iOS?

takahirom commented 1 year ago

Let me rerun the job 🙏

syam4869 commented 1 year ago

PR work has been completed. Please take a moment to review.