[Android] show snackbar message - Githubissues

DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023

Apache License 2.0

645 stars 206 forks source link

[Android] show snackbar message #1106

Closed ked4ma closed 1 year ago

ked4ma commented 1 year ago

Issue

close #1101

Overview (Required)

Now, snackbar will be shown without any messages (only "Retry" is dispalyed).
In this PR, fix enabling to display message.
If message and cause is passed to RuntimeException class's constructor, message of exception will be set the value of indicated variable value.
- the default value of message on AppError's constructor is null (ref)
- so, I think message will be always null because message is not indicated on any classes's constructor inheritting AppError class

Links

https://github.com/JetBrains/kotlin/blob/10e94f90ac1b2396d0427d9078c1fe481859cb60/libraries/stdlib/jvm/runtime/kotlin/TypeAliases.kt#L13

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before	After

github-actions[bot] commented 1 year ago

Test Results

211 tests 211 :heavy_check_mark: 6m 27s :stopwatch:   11 suites     0 :zzz:   11 files     0 :x:

Results for commit acd80f7d.