[Android] fix bottom padding on contributor screen

DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023

Apache License 2.0

645 stars 206 forks source link

[Android] fix bottom padding on contributor screen #1107

Closed ked4ma closed 1 year ago

ked4ma commented 1 year ago

Issue

NO_ISSUE

Overview (Required)

As following image(Before), bottom element of contributor will be buried behind the navbar.
- with some device, snackbar is not displayed due to the navbar.
Now, contributor screen is move into about screen
- so I tried to change padding setting same as staff and sponsor screen to enable to show bottom element and snackbar.
This doesn't have an issue ticket, so if it's AWFUL change, please close this PR :bow:

Screenshot (Optional if screenshot test is present or unrelated to UI)

device	Before	After
Pixel 6 api 30
Pixel Fold api 33

takahirom commented 1 year ago

Our policy for inset padding is this. Do you have any idea why it doesn't work? https://github.com/DroidKaigi/conference-app-2023/pull/959#discussion_r1306396623

github-actions[bot] commented 1 year ago

Test Results

211 tests 211 :heavy_check_mark: 8m 45s :stopwatch:   11 suites     0 :zzz:   11 files     0 :x:

Results for commit 8a19b25c.

ked4ma commented 1 year ago

@takahirom

Our policy for inset padding is this. Do you have any idea why it doesn't work? #959 (comment)

I this it's because ContributorScreen is not in the mainNestedGraph now. In #959, contentPadding is passed from mainNestedGraph and had been using it for showing ContributorScreen. But now, this is moved into the KaigiNavHost func. And this func doesn't have padding information so ContributorScreen will use default PaddingValues . By default, PaddingValues have 0dp for horizontal and vertical. As a result, I think how to do padding was changed :thinking: