Closed syarihu closed 1 year ago
Hi @syarihu! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct
and fix the results of ./gradlew lintDebug.. Thank you for your contribution.
We've attempted this. However, there's an issue where the tests can't recognize the Dagger Module of the app-android module. I believe the tests will fail. π https://github.com/DroidKaigi/conference-app-2023/pull/782
@takahirom Thanks for sharing about your previous issues. I have created a BuildConfigProviderModule that provides an empty BuildConfigProvider that can override the Provider using BindsOptionalOf in the data module. Then, by overriding that setting in the AppModule, app-android was able to return values from BuildConfig while providing an empty BuildConfigProvider in the test. I think this also makes all the test code PASS. In my environment, I passed all of them. What do you think of this?
Snapshot diff report | File name | Image |
---|---|---|
AboutScreenTest.chec kScrollShot_3_compar e.png |
||
AboutScreenTest.chec kScrollShot_2_compar e.png |
211 testsβββ211 :heavy_check_mark:ββ7m 49s :stopwatch: ββ11 suitesββββββ0 :zzz: ββ11 filesββββββββ0 :x:
Results for commit 4db99a16.
@matsumo0922 For your reference, the issue is fixed now! π
Thanks for your review and merge!
Issue
Overview (Required)
Detail
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)