Closed ked4ma closed 11 months ago
Hi @ked4ma! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct
and fix the results of ./gradlew lintDebug.. Thank you for your contribution.
215 tests 215 :heavy_check_mark: 8m 28s :stopwatch: 11 suites 0 :zzz: 11 files 0 :x:
Results for commit 5e7f7cf9.
:recycle: This comment has been updated with latest results.
Issue
Overview (Required)
before
movie)WHY the behavior like this
■ when simply adding bookmark
expand for detail...
| onBookmarkClickState | isPlaying | progress | remarks | | :--: | :--: | :--: | :--: | NULL | FALSE | | [[at first]] TRUE | FALSE | | when click bookmark icon TRUE | TRUE | 0 | start animation TRUE | TRUE | ~1.0 | TRUE | FALSE | 1 | call onReachAnimationEnd() FALSE | FALSE | 1 | FALSE | TRUE | 1 | isPlay will be TRUE because onBookmarkClickState is updated FALSE | FALSE | 0 | TRUE | FALSE | 0 | [[second click]] TRUE | TRUE | 0 | start animation TRUE | TRUE | ~1.0 | TRUE | FALSE | 1 | call onReachAnimationEnd() FALSE | FALSE | 1 | FALSE | TRUE | 1 | isPlay will be TRUE because onBookmarkClickState is updated FALSE | FALSE | 0 |■ when go back from bookmark list (before going to bookmark list, adding bookmark)
※1,2): operated in one composable execution
the problem here is
expand for detail...
isPlaying will not be TRUE again because onBookmarkClickState is FALSE at first TRUE | FALSE | 1 | [[second click]] TRUE※1 | TRUE※1 | 1 | isPlaying become TRUE (∵onBookmarkClickState is TRUE) FALSE※2 | FALSE※2 | 1 | onBookmarkClickState will be updated to FALSE becuase progress is 1.0 FALSE | TRUE | 0 | start animation becuase onBookmarkState is updated FALSE | TRUE | ~1.0 | FALSE | FALSE | 1 | onReachAnimationEnd() isPlaying will not be TRUE again because onBookmarkClickState is FALSE (unchanged) | | | |
I fix this issue by changing how to judge "animation is finished"
progress
■ when simply adding bookmark
expand for detail...
onBookmarkClickState | isPlaying | progress(state) | isPlaying(state) | isAtEnd(state) | remarks -- | -- | -- | -- | -- | -- FALSE | FALSE | 0 | FALSE | TRUE | [[at first]] TRUE | FALSE | 0 | FALSE | TRUE | when click bookmark icon TRUE | TRUE | 0 | TRUE | FALSE | start animation TRUE | TRUE | ~1.0 | TRUE | FALSE | TRUE | TRUE | 1 | TRUE | TRUE | when animation finished FALSE | FALSE | 1 | FALSE | TRUE | animation state is updated according to isPlaying TRUE | FALSE | 1 | FALSE | TRUE | [[second click]] TRUE | TRUE | 0 | TRUE | FALSE | start animation TRUE | TRUE | ~1.0 | TRUE | FALSE | TRUE | TRUE | 1 | TRUE | TRUE | when animation finished FALSE | FALSE | 1 | FALSE | TRUE | animation state is updated according to isPlaying■ when go back from bookmark list (before going to bookmark list, adding bookmark)
expand for detail...
onBookmarkClickState | isPlaying | progress(state) | isPlaying(state) | isAtEnd(state) | remarks -- | -- | -- | -- | -- | -- FALSE | FALSE | 0 | FALSE | TRUE | animation won't start because isPlaying will be TRUE only when onBookmarkClickState is TRUELinks
Movie