Adjust Timetable App Bar Bookmark Icon State

[ked4ma]

Issue

• close #1116

Overview (Required)

• bookmark icon has unexpected behaviors at app bar on timetable screen (refer before movie)
• HOT to REPRODUCTION
  1. add bookmark on timetable list screen
  2. go to bookmark screen
  3. go back to timetable list screen

• WHY the behavior like this

  • ■ when simply adding bookmark

    expand for detail...

    | onBookmarkClickState | isPlaying | progress | remarks | | :--: | :--: | :--: | :--: | NULL | FALSE |   | [[at first]] TRUE | FALSE |   | when click bookmark icon TRUE | TRUE | 0 | start animation TRUE | TRUE | ~1.0 |   TRUE | FALSE | 1 | call onReachAnimationEnd() FALSE | FALSE | 1 |   FALSE | TRUE | 1 | isPlay will be TRUE because onBookmarkClickState is updated FALSE | FALSE | 0 |   TRUE | FALSE | 0 | [[second click]] TRUE | TRUE | 0 | start animation TRUE | TRUE | ~1.0 |   TRUE | FALSE | 1 | call onReachAnimationEnd() FALSE | FALSE | 1 |   FALSE | TRUE | 1 | isPlay will be TRUE because onBookmarkClickState is updated FALSE | FALSE | 0 |  

  • ■ when go back from bookmark list (before going to bookmark list, adding bookmark)

  • ※1,2): operated in one composable execution

  • the problem here is

    • onBookmarkClickState is false at first
    • onBookmarkClickState is false right after click bookmark
      expand for detail...

    onBookmarkClickState	isPlaying	progress	remarks
    FALSE	TRUE	0	animation is started because onBookmarkClickState is NOT null
    FALSE	TRUE	~1.0
    FALSE	FALSE	1	onReachAnimationEnd()

    isPlaying will not be TRUE again because onBookmarkClickState is FALSE at first TRUE | FALSE | 1 | [[second click]] TRUE※1 | TRUE※1 | 1 | isPlaying become TRUE (∵onBookmarkClickState is TRUE) FALSE※2 | FALSE※2 | 1 | onBookmarkClickState will be updated to FALSE becuase progress is 1.0 FALSE | TRUE | 0 | start animation becuase onBookmarkState is updated FALSE | TRUE | ~1.0 |   FALSE | FALSE | 1 | onReachAnimationEnd() isPlaying will not be TRUE again because onBookmarkClickState is FALSE (unchanged) | | | |

• I fix this issue by changing how to judge "animation is finished"

  • use LottieAnimationState (isPlaying, isAtEnd, progress) instead of using only progress
  • as a result, first null value of onBookmarkClickState and animationRange could remove
  • by this, variables arround animation are changed as following

  • ■ when simply adding bookmark

    expand for detail...

    onBookmarkClickState | isPlaying | progress(state) | isPlaying(state) | isAtEnd(state) | remarks -- | -- | -- | -- | -- | -- FALSE | FALSE | 0 | FALSE | TRUE | [[at first]] TRUE | FALSE | 0 | FALSE | TRUE | when click bookmark icon TRUE | TRUE | 0 | TRUE | FALSE | start animation TRUE | TRUE | ~1.0 | TRUE | FALSE |   TRUE | TRUE | 1 | TRUE | TRUE | when animation finished FALSE | FALSE | 1 | FALSE | TRUE | animation state is updated according to isPlaying TRUE | FALSE | 1 | FALSE | TRUE | [[second click]] TRUE | TRUE | 0 | TRUE | FALSE | start animation TRUE | TRUE | ~1.0 | TRUE | FALSE |   TRUE | TRUE | 1 | TRUE | TRUE | when animation finished FALSE | FALSE | 1 | FALSE | TRUE | animation state is updated according to isPlaying

  • ■ when go back from bookmark list (before going to bookmark list, adding bookmark)

    expand for detail...

    onBookmarkClickState | isPlaying | progress(state) | isPlaying(state) | isAtEnd(state) | remarks -- | -- | -- | -- | -- | -- FALSE | FALSE | 0 | FALSE | TRUE | animation won't start because isPlaying will be TRUE only when onBookmarkClickState is TRUE

    Links

• nothing

Movie

Before	After

[github-actions[bot]]

Hi @ked4ma! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

[github-actions[bot]]

Test Results

215 tests   215 :heavy_check_mark:  8m 28s :stopwatch:   11 suites      0 :zzz:   11 files        0 :x:

Results for commit 5e7f7cf9.

:recycle: This comment has been updated with latest results.