[iOS] Use the defined Typography on each screen.

DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023

Apache License 2.0

645 stars 207 forks source link

[iOS] Use the defined Typography on each screen. #1144

Closed Corvus400 closed 11 months ago

Corvus400 commented 11 months ago

Summary

Use the Typography implemented in task #889 on each screen.

Corvus400 commented 11 months ago

@ry-itto @tkhs0604 I would like to do this task.🙋

Corvus400 commented 11 months ago

Before we do this task, do we also need to do a task to combine each of the prepared theme files into a file like Theme.kt and provide it as a theme? 🤔

momomomo111 commented 11 months ago

@Corvus400 I don't know about the iOS details, but I have assigned them. Thanks for working on it.

Corvus400 commented 11 months ago

@ry-itto @tkhs0604

Let me ask a question.🙋 I cannot see the preview on any of the screens as shown in the image attached now. I may be missing some necessary operation, but do you know how to make the preview appear? . /gradlew assembleSharedXCFramework, but there is no change. It is quite difficult to apply fonts when the preview is not displayed. If you know how to solve this problem, please let me know. :bow:

ry-itto commented 11 months ago

@Corvus400 It seems to be a Xcode Beta problem 🙏🏼

As for the PreviewProvider issue sounds like a separate and not tracked issue. https://developer.apple.com/forums/thread/731887

Corvus400 commented 11 months ago

@ry-itto Oh my...so it looks like you can't get the preview to work on its own.😭

ry-itto commented 11 months ago

Sorry... Please check that with builded app 🙏🏼