search

DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023
Apache License 2.0
645 stars 207 forks source link

Hide title when enable the BigFont/BigDisplay in ContributorsScreen #1151

Open kosenda opened 11 months ago

kosenda commented 11 months ago

Issue

Overview (Required)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

When BigFont/BigDisplay is disabled, Before and After are different, but as far as Figma shows, the same Style is applied, so I do not think there is any problem. https://www.figma.com/file/MbElhCEnjqnuodmvwabh9K/DroidKaigi-2023-App-UI?type=design&node-id=55032-59308&mode=dev

Settings Before After
github-actions[bot] commented 11 months ago

Test Results

215 tests   215 :heavy_check_mark:  6m 38s :stopwatch:   11 suites      0 :zzz:   11 files        0 :x:

Results for commit 0769262e.

:recycle: This comment has been updated with latest results.

takahirom commented 11 months ago

Could you add screenshot tests for this? Maybe we could break this unexpectedly 🙏

kosenda commented 11 months ago

@takahirom Sorry, I was not able to make a screenshot 🙇 So, I would like to either raise an issue to add a new test or not close this issue.

Since there was no screenshot test for ContributorsScreen, I first tried to create a ContributorsScreenRobot, but I could not prepare a ContributorsViewModel to test it. If I set = hiltViewModel() as the default argument for ContributorsViewModel in ContributorsScreen as I do for other screens, I can test ContributorsScreenRobot with ContributorsViewModel in ContributorsScreenRobot, but I gave up because I couldn't get the dependencies right.

takahirom commented 11 months ago

I think you can try to use androidMain { dependencies { implement(libs.xxxx) } } 👀

kosenda commented 11 months ago

Thank you! I'll try it!

takahirom commented 11 months ago

Sorry, we should use androidUnitTest like this. Because androidMain will affect the main artifact.

    androidUnitTest {
        dependencies {

        }
    }
kosenda commented 11 months ago

@takahirom Sorry for repeating 🙇 I have tried test, but I don't know how to test it at all, so I would like to either create a new issue for testing or not close the issue.