DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023
Apache License 2.0
645 stars 207 forks source link

Add detekt run configuration for format #1162

Closed att55 closed 11 months ago

att55 commented 11 months ago

Issue

Overview (Required)

I add Spotless run configuration for format.

As I had asked before, I reinstalled Spotless. https://github.com/DroidKaigi/conference-app-2023/issues/1034#issuecomment-1703854345

Is what I did correct?

I add a configuration to run detekt.

Screenshot (Optional if screenshot test is present or unrelated to UI)

スクリーンショット 2023-09-12 0 10 57
github-actions[bot] commented 11 months ago

Test Results

215 tests   215 :heavy_check_mark:  8m 53s :stopwatch:   11 suites      0 :zzz:   11 files        0 :x:

Results for commit e3a90cd6.

:recycle: This comment has been updated with latest results.

takahirom commented 11 months ago

We are using detekt like this. ./gradlew detekt --auto-correct It uses ktlint internally. So we don't have to introduce spotless. 👀

att55 commented 11 months ago

@takahirom Thank you for your reply! So, I should have added a configuration file for detekt.

I removed spotless and added a configuration file to run for detekt. Please check again. 🙏🏼

スクリーンショット 2023-09-12 0 10 57