[iOS] Improve iOS TimetableDayHeader performance - Githubissues

DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023

Apache License 2.0

645 stars 207 forks source link

[iOS] Improve iOS TimetableDayHeader performance #1163

Closed ry-itto closed 11 months ago

ry-itto commented 11 months ago

Issue

close #1075

Overview (Required)

This is caused by circular reference between TimetableViewModel instance and TimetabeListView 's closure ( toggleBookmark ).
Currently, SwiftUI rendering is recursively called and it is caused by above.

ref: https://developer.apple.com/forums/thread/126890

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before	After

Movie (Optional)

Before	After