DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023
Apache License 2.0
645 stars 207 forks source link

[Proposal/Experimental] :recycle: I implemented the timetable droid-kun to blink. #1176

Closed Corvus400 closed 11 months ago

Corvus400 commented 11 months ago

Issue

Overview (Required)

Movie (Optional)

Light Dark
github-actions[bot] commented 11 months ago
Snapshot diff report File name Image
KaigiAppTest.checkTi
metableTabs_compare.
png
KaigiAppTest.checkTi
metableTabs_2_compar
e.png
KaigiAppTest.checkTi
metableTabs_3_compar
e.png
io.github.droidkaigi
.confsched2023.sessi
ons_null_Theme_Previ
ewTimetableScreenDar
k-LightMode-1_1_null
_compare.png
KaigiAppTest.checkSt
artupShot_compare.pn
g
io.github.droidkaigi
.confsched2023.sessi
ons_null_Theme_Previ
ewTimetableScreenDar
k-DarkMode-1_2null
compare.png
KaigiAppTest.checkMe
diumTabletLaunchShot
_compare.png
TimetableScreenTest.
checkLaunchServerErr
orShot_compare.png
TimetableScreenTest.
checkSmallFontScaleS
hot_compare.png
TimetableScreenTest.
checkLaunchShot_comp
are.png
TimetableScreenTest.
checkBookmarkToggleS
hot_compare.png
TimetableScreenTest.
checkGridShot_compar
e.png
TimetableScreenTest.
checkBookmarkToggleS
hot_2_compare.png
github-actions[bot] commented 11 months ago

Test Results

215 tests   215 :heavy_check_mark:  7m 59s :stopwatch:   11 suites      0 :zzz:   11 files        0 :x:

Results for commit 4acee25d.

:recycle: This comment has been updated with latest results.

takahirom commented 11 months ago

I got designer's feedback. Could you improve it?

目を閉じている時間は短めにして欲しいです!イメージは↓の感じです... 目開きっぱなし約2秒→瞬き2回(ループ) (理由:目を閉じた時の目の太さは口の線の太さと同じぐらいになるが、今の実装だと目が細くなるので違和感ありです :おじぎ::肌色-2:...)

Corvus400 commented 11 months ago

@takahirom I modified it like this, how do you like it?

https://github.com/DroidKaigi/conference-app-2023/assets/13657682/02a8d3e9-1ea9-4c4f-aa0f-ba91063b08e1