search

DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023
Apache License 2.0
636 stars 206 forks source link

When I create a PR for iOS code, I cannot assign a reviewer. #1186

Closed Corvus400 closed 10 months ago

Corvus400 commented 10 months ago

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Code to change only the iOS side code (Swift file) as PR
  2. No reviewers are assigned when a PR is created.

Expected behavior Reviewers will be assigned appropriately, just as they would be if the Android side of the code were changed.

Link https://github.com/DroidKaigi/conference-app-2023/blob/main/.github/CODEOWNERS#L2

tkhs0604 commented 10 months ago

@Corvus400 Hmm... For example, a reviewer group for iOS side seems to be add automatically in https://github.com/DroidKaigi/conference-app-2023/pull/1195... 🤔 This group looks recognized as a codeowner properly. Screenshot 2023-09-12 at 22 46 23

Corvus400 commented 10 months ago

@tkhs0604 No one seems to be assigned on my end. 🤔 Perhaps other iOS PRs I have created have been assigned that AppiOS? 👻

image
tkhs0604 commented 10 months ago

Ah, it's because the above PR is still draft. If I open the PR once, iOS team will be assigned as a reviewer 👀 image

Perhaps other iOS PRs I have created have been assigned that AppiOS? 👻

To be honest, I am not sure what happens to your local 🙏 But if this is not your manual operation, the answer must be yes 👍 Ex: https://github.com/DroidKaigi/conference-app-2023/pull/1178 image

tarumzu commented 10 months ago

@tkhs0604 cc @Corvus400 I see. We just can't see it because your team visibility is Secret. As shown below, You are in "a team", so We cannot see your assignment.

Screen Shot 2023-09-12 at 23 42 25

ConferenceApp2023Reviewer probably has "Enable auto assignment" enabled.

tkhs0604 commented 10 months ago

@tarumzu Thank you for your further investigation! The AppiOS team must be visible (here), but "Enable auto assignment" might not be applied to this team 🤔 In fact, I don't have access to this settings, so let me take this topic back to admin members 🙏

tarumzu commented 10 months ago

@tkhs0604 Your welcome! However, if your team has been assigned, further action may be unnecessary.

Corvus400 commented 10 months ago

@tkhs0604 @tarumzu Even though I couldn't see it from the contributor's side, I knew that someone from the iOS team was assigned to the reviewer, and that was a relief.😌

tkhs0604 commented 10 months ago

Thank you both! I learned a lot from your comments! Then, let me close this issue at this time 🙏 I hope we can improve the PR review flow next time 💪