Fix timetable detail section loading animation - Githubissues

DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023

Apache License 2.0

636 stars 206 forks source link

Fix timetable detail section loading animation #1216

Closed matsumo0922 closed 10 months ago

matsumo0922 commented 10 months ago

Issue

TimetableDetailScreen animation is unnatural.

Overview (Required)

The contentKey was introduced in #982, but during the initial animation, there is a moment when the content is not displayed, and the loaded section is drawn from there, resulting in a scaled animation that is unnatural.
Therefore, only the Loading section is faded animated without AnimatedContent.
- In the first place, this loading never takes more than a few seconds (for local), so I feel that the switching animation is not necessary.

Movie

Before	After

github-actions[bot] commented 10 months ago

Test Results

215 tests 215 :heavy_check_mark: 9m 44s :stopwatch:   11 suites     0 :zzz:   11 files     0 :x:

Results for commit 86776ff8.

:recycle: This comment has been updated with latest results.