[Android] select first timetable tab on TimetableScreenTest

[ked4ma]

Issue

• close #1217

Overview (Required)

• Today is Day2 of DroidKaigi2023.
• TimetableScreen initialize own selected tab with current date.
• So, if we run snapshot test for timetable, the Day2 tab will be selected as default.
  • (tomorrow, day3 tab will be selected)
• By above reason, there are some differences on snapshot comparing test.
• For the consistent test result, fix selected tab to Day1.
• (addition) this problem is also occured on PreviewTest.
  • thus, I changed to return Day1 from initialSelectedDay if it's on test.

Links

• https://github.com/DroidKaigi/conference-app-2023/pull/1216#issuecomment-1719867788

Screenshot (Optional if screenshot test is present or unrelated to UI)

※Following screenshots are samples because target snapshots are little bit too many to show here :bow:

Before	After

[takahirom]

Thanks! Let's see if screenshots works. I made a issue for fixing this for the better solution. https://github.com/DroidKaigi/conference-app-2023/issues/1219

[github-actions[bot]]

Test Results

215 tests   215 :heavy_check_mark:  10m 46s :stopwatch:   11 suites      0 :zzz:   11 files        0 :x:

Results for commit 06f26869.

:recycle: This comment has been updated with latest results.

[ked4ma]

Umm. Unit test is failed :thinking:

[ked4ma]

:notebook:

io.github.droidkaigi.confsched2023.PreviewTest > previewScreenshot[91] FAILED
    java.lang.IllegalArgumentException at PreviewTest.kt:39

io.github.droidkaigi.confsched2023.PreviewTest > previewScreenshot[92] FAILED
    java.lang.IllegalArgumentException at PreviewTest.kt:39

[takahirom]

previewScreenshot[91]
java.lang.IllegalArgumentException: Required value was null.
    at io.github.droidkaigi.confsched2023.sessions.section.TimetableSheetKt$TimetableSheet$1.invoke(TimetableSheet.kt:113)
    at io.github.droidkaigi.confsched2023.sessions.section.TimetableSheetKt$TimetableSheet$1.invoke(TimetableSheet.kt:70)
    at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
    at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
    at androidx.compose.material3.SurfaceKt$Surface$1.invoke(Surface.kt:132)
    at androidx.compose.material3.SurfaceKt$Surface$1.invoke(Surface.kt:114)
    at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
    at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
    at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228)
    at androidx.compose.material3.SurfaceKt.Surface-T9BRK9s(Surface.kt:111)
    at io.github.droidkaigi.confsched2023.sessions.section.TimetableSheetKt.TimetableSheet(TimetableSheet.kt:67)
    at io.github.droidkaigi.confsched2023.sessions.TimetableScreenKt$TimetableScreen$8.invoke(TimetableScreen.kt:216)
    at io.github.droidkaigi.confsched2023.sessions.TimetableScreenKt$TimetableScreen$8.invoke(TimetableScreen.kt:203)
    at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:117)

[takahirom]

uiState = requireNotNull(uiState.timetableListUiStates[selectedDay]) 👀

[ked4ma]

timetable list of uiState for preview is also designed with the first day in mind, maybe :thinking: I'll try to extend TimetableSheet (and arround that)

[github-actions[bot]]

Hi @ked4ma! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

[ked4ma]

:notebook: all test have hassed. and it seems that there are no diff.