search

DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023
Apache License 2.0
644 stars 206 forks source link

Time Display on TimetableGrid is Off by One Hour #1226

Closed takahirom closed 1 year ago

takahirom commented 1 year ago

Idea Description The time displayed on the TimetableGrid is one hour behind the actual scheduled time.

image

For now, we released a hotfix veresion that we remove the time as 1.6.1.

image

Reference images and links

aqua-ix commented 1 year ago

🙋

tkhs0604 commented 1 year ago

Thank you for your help! Assigned!

aqua-ix commented 1 year ago

As a clue, there may be a problem with the following calculations or related variables:

https://github.com/DroidKaigi/conference-app-2023/blob/e52ff00429ff30d1b58433f74b20cef83763e7c7/feature/sessions/src/main/java/io/github/droidkaigi/confsched2023/sessions/section/TimetableGrid.kt#L360

It's possible that dayStart always needs to be set to 10:00(JST).

aqua-ix commented 1 year ago

It's possible that dayStart always needs to be set to 10:00(JST).

It seems to be correct, so I'll try implementing it.

takahirom commented 1 year ago

Thanks