search

DroidKaigi / conference-app-2023

The Official Conference App for DroidKaigi 2023
Apache License 2.0
646 stars 206 forks source link

Can't see the `TimetableList` or `TimetableGrid` when the phone is in landscape mode. #531

Open kosenda opened 1 year ago

kosenda commented 1 year ago

Sorry if this is a known bug.

Describe the bug Can't see the TimetableList or TimetableGrid when the phone is in landscape mode.

https://github.com/DroidKaigi/conference-app-2023/blob/898f3bb57cb7d7f79c8ab584651f2ee101d07dc5/feature/sessions/src/main/java/io/github/droidkaigi/confsched2023/sessions/section/TimetableSheet.kt#L91

To Reproduce Steps to reproduce the behavior:

  1. Launch the application
  2. Turn the screen sideways

Expected behavior TimetableList or TimetableGrid is visible.

Screenshots phone: Pixel6

https://github.com/DroidKaigi/conference-app-2023/assets/60963155/fbb2906c-c17e-454b-9817-e2c21757b79f

takahirom commented 1 year ago

I didn't notice this! Thanks!

Masaki-U commented 1 year ago

@takahirom 🙋 I'd like to try this issue!

mhidaka commented 1 year ago

@Masaki-U Thank you for your interest ✨ I Assigned you.

Masaki-U commented 1 year ago

@takahirom @mhidaka It seems to me that this issue has been resolved by moving the bottom bar to the sidebar in landscape mode. How do you see it? Regarding the implementation status, I have resolved it everywhere except for our custom LazyLayout grid timetable, but after that, it's been challenging.

https://github.com/DroidKaigi/conference-app-2023/pull/968

https://github.com/DroidKaigi/conference-app-2023/assets/42033804/de8bb677-7c59-4426-843a-37b051745a3a

takahirom commented 1 year ago

@Masaki-U I think we can remove this issue! How about adding a screenshot test for the landscape timetable to check continually?

ked4ma commented 1 year ago

Excuse me for jumping in :pray:

If running on NexusOne (using it for Roborazzi snapshot test), it seems navbar is displayed at bottom on screen. :thinking: (maybe due to the NexusOne's screen size)

nexusone.webm

And if you run on little bit larger device (i.e. PixelXL), navigation rail will change layout as following. (additional landscape screenshot sample on PixelXL)

How do you think we should handle this??

takahirom commented 1 year ago

We used Nexus One to save money when we are closed source. So we don't have to think about Nexus One anymore. It is better to support small devices though. 👀