DroidKaigi / conference-app-2024

The Official Conference App for DroidKaigi 2024
Apache License 2.0
453 stars 201 forks source link

:memo: [Proposal][SearchScreenTest] The robots were separated according to their roles. #1000

Open Corvus400 opened 1 month ago

Corvus400 commented 1 month ago

Issue

Overview (Required)

github-actions[bot] commented 1 month ago

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

takahirom commented 1 month ago

What I want to focus on is that when we create or modify something, it's better if the number of files or the distance of each edit we need to modify is small. I think if we filter something on the search screen, we want to check the filter, and this change requires us to make multiple file modifications.

Corvus400 commented 1 month ago

I see... Since the current scale is this number of lines, if we add more tests, it is easy to predict that the number of lines will easily reach four or five digits, so I would like to hear any good ideas you may have. :bow:

takahirom commented 1 month ago

I think we need to focus on the developer's workflow to understand which changes are made together and consolidate them into the same class or something similar. This is what you changed, and I think we can create a SearchFilterRobot.

ab215606

I believe this kind of change is better because it makes our development more smooth.

class SearchScreenRobot {
  val searchFilterRobot 

  class SearchFilterRobot()
}
Corvus400 commented 1 month ago

Understood. :saluting_face: Instead of dividing the robot into three parts, I'll try dividing the classes within the robot and moving the processing to them. :muscle: