search

DroidKaigi / conference-app-2024

The Official Conference App for DroidKaigi 2024
Apache License 2.0
458 stars 200 forks source link

[iOS] refactor AboutView: improve button tap area & fix spacing & commonalize style #1025

Closed yuukiw00w closed 2 months ago

yuukiw00w commented 2 months ago

Overview (Required)

  1. include the padding areas, expanding the tap area to the full width.

  2. fix spacing（Because VStack has default spacing, need to set spacing: 0）

  3. commonalize spacing and ButtonStyle

and minor fixes(add opacity animation, add ButtonStyle & LabelStyle extension, remove unnecessary frame settings, etc)

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After
before1 after1
before2 after2

Movie

Before After
before3 after3

Other comment

I enabled the "Button Shapes" for testing purposes and confirmed that it causes the design to break. If there is no existing issue for this, it might be a good idea to create one.

yuukiw00w commented 2 months ago

I enabled the "Button Shapes" for testing purposes and confirmed that it causes the design to break. If there is no existing issue for this, it might be a good idea to create one.

I fixed this problem in #1029