DroidKaigi / conference-app-2024

The Official Conference App for DroidKaigi 2024
Apache License 2.0
429 stars 199 forks source link

Add TimetableItemDetailScreenTest checks #282

Closed takahirom closed 1 month ago

takahirom commented 1 month ago

We can run the test by clicking the "Run" button on the left side of Android Studio.

image

Please add some test checks for the TimetableItemDetailScreen. The current code looks like this:

                    describe("click first session bookmark") {
                        run {
                            clickFirstSessionBookmark()
                        }
                        itShould("show bookmarked session") {
                            // FIXME: Add check for bookmarked session
                            captureScreenWithChecks()
                        }
                    }

We would like to add some checks similar to other tests. Please add a check like checkBookmarkedSessionDisplayed() in the robot and implement it.

                    itShould("show timetable items") {
                        captureScreenWithChecks(checks = {
                            checkTimetableItemsDisplayed()
                        })
                    }

It looks like there are 7 checks to fix in the TimetableItemDetailScreenTest.

https://github.com/DroidKaigi/conference-app-2024/blob/0a15d6b930e981217645ecd0d1be5bde4d412f22/feature/sessions/src/androidUnitTest/kotlin/io/github/droidkaigi/confsched/sessions/TimetableItemDetailScreenTest.kt#L58-L59

Corvus400 commented 1 month ago

I've finished other tasks, so I'd like to start working on this one. 🙋

takahirom commented 1 month ago

@Corvus400 Thanks! Assigned 👍