search

DroidKaigi / conference-app-2024

The Official Conference App for DroidKaigi 2024
Apache License 2.0
410 stars 200 forks source link

Fix typo of tests #342

Closed takahirom closed 4 weeks ago

takahirom commented 1 month ago

We can run the test by clicking the "Run" button on the left side of Android Studio.

image

The itShould text is wrong.

This should be "large" instead of "small" https://github.com/DroidKaigi/conference-app-2024/blob/857318244a16a3bfa312fcadd367636c8fa09d6e/feature/sessions/src/androidUnitTest/kotlin/io/github/droidkaigi/confsched/sessions/TimetableItemDetailScreenTest.kt#L107C35-L107C50

huge https://github.com/DroidKaigi/conference-app-2024/blob/857318244a16a3bfa312fcadd367636c8fa09d6e/feature/sessions/src/androidUnitTest/kotlin/io/github/droidkaigi/confsched/sessions/TimetableItemDetailScreenTest.kt#L116

yuheikawakami commented 1 month ago

🙋

takahirom commented 1 month ago

Thanks! Assigned 👍

yuheikawakami commented 4 weeks ago

@takahirom This typo seemes to have been fixed in the Pull Request shown below 🙏 🙏

https://github.com/DroidKaigi/conference-app-2024/pull/373/files#diff-41c2958f0b6d8f3b3f27d0a369a44421e9257cd33d7f7e49b00446591835010fR127

https://github.com/DroidKaigi/conference-app-2024/pull/373/files#diff-41c2958f0b6d8f3b3f27d0a369a44421e9257cd33d7f7e49b00446591835010fR143

takahirom commented 4 weeks ago

I'm sorry. I didn't notice that. I'm looking for your next contribution.