search

DroidKaigi / conference-app-2024

The Official Conference App for DroidKaigi 2024
Apache License 2.0
448 stars 201 forks source link

Rename maxAboutHeaderOffsetDp to MaxAboutHeaderOffsetDp #462

Closed takahirom closed 2 months ago

takahirom commented 2 months ago

Super easy

https://github.com/DroidKaigi/conference-app-2024/blob/77ea7494cb8eb6cdde93726b25970c2ecc06210f/feature/about/src/commonMain/kotlin/io/github/droidkaigi/confsched/about/section/AboutDroidKaigiDetail.kt#L33

soleil-colza commented 2 months ago

Hi! Would like to work on this issue☺️ @takahirom

takahirom commented 2 months ago

I think you could handle more challenging tasks. 😄 Anyway, assigned. 👍

soleil-colza commented 2 months ago

I think you could handle more challenging tasks. 😄

Honoured to be said so though I was a bit afraid of picking up a harder task😅 I will regard this issue as a good warm-up and request working on harder ones afterwards!!

soleil-colza commented 2 months ago

@takahirom Deep apologies for mentioning you multiple times, looking into the issue it seems to be way easier than I thought. I feel like it's better to let novices work on this as a first step, so if you feel the same way could you please unassign me from this? It's totally up to you, thank you🙇🏻‍♀️

takahirom commented 2 months ago

Thank you for your cooperation in helping beginners! 🙏

arcenjoyed commented 2 months ago

I'm a beginner but I wanna give it a try! @takahirom

takahirom commented 2 months ago

Thanks! Assigned 👍