DroidKaigi / conference-app-2024

The Official Conference App for DroidKaigi 2024
Apache License 2.0
410 stars 200 forks source link

Verify displayed items instead of verifying the list's existence in `xxxxScreenTest` tests #464

Open takahirom opened 4 weeks ago

takahirom commented 4 weeks ago

We should check if the items exist. The list is still a list even when it's empty.

Corvus400 commented 4 weeks ago

I would like to work on this issue. :hand: You mean correcting these kinds of tests, right? https://github.com/DroidKaigi/conference-app-2024/pull/395#discussion_r1716187285

takahirom commented 4 weeks ago

Yes, that's what I mean. Thanks!

iamayushsharmaa commented 4 weeks ago

I would like to work on this issue

464

takahirom commented 4 weeks ago

@iamayushsharmaa Thank you for raising your hand. This issue has already been assigned. However, since there are many screens to fix, if you have a specific screen you'd like to work on, please let me know the name. I think we can collaborate to address this issue.

iamayushsharmaa commented 4 weeks ago

yeah sure

Corvus400 commented 3 weeks ago

The contents of FavoritesScreenTest also need to be modified, but we are working on the following PR, so we will check the contents after they are merged and modify them again if there are any shortcomings. https://github.com/DroidKaigi/conference-app-2024/pull/569

Corvus400 commented 3 weeks ago

Confirmation of remaining tasks