search

DroidKaigi / conference-app-2024

The Official Conference App for DroidKaigi 2024
Apache License 2.0
410 stars 200 forks source link

Adjust the spacing between the up button and title to match the Figma design. #702

Closed takahirom closed 1 week ago

takahirom commented 3 weeks ago
image image

https://www.figma.com/design/XUk8WMbKCeIdWD5cz9P9JC/DroidKaigi-2024-App-UI?node-id=54795-26746

choi-woo-sung commented 3 weeks ago

🙋

takahirom commented 3 weeks ago

Thanks! Assigned 👍

choi-woo-sung commented 3 weeks ago

@takahirom I'm looking at the code and it is currently using LargeTopAppBar and it has 28dp embedded internally. Should I create a new topbar?

takahirom commented 3 weeks ago

I'm not sure, but can we use medium? https://developer.android.com/develop/ui/compose/components/app-bars#medium

choi-woo-sung commented 2 weeks ago

@takahirom thank you

image
choi-woo-sung commented 1 week ago

@takahirom I dont 'know why test fail....

takahirom commented 1 week ago

Thank you for letting me know! Don't worry. First, I think you can remove the unused import.

https://github.com/DroidKaigi/conference-app-2024/actions/runs/10633335229/job/29479517095?pr=753

e: file:///home/runner/work/conference-app-2024/conference-app-2024/feature/contributors/src/commonMain/kotlin/io/github/droidkaigi/confsched/contributors/ContributorsScreen.kt:29:52 Unresolved reference 'handleOnClickIfNotNavigating'.

Second, you can open SponsorsScreenTest and click Run the test!

image

And then the supporters are not displayed.

image 
SponsorsScreenTest > runTest[SponsorsScreen - when server is operational - when launch - when scroll to supporters header - it should display supporters sponsors] STARTED

SponsorsScreenTest > runTest[SponsorsScreen - when server is operational - when launch - when scroll to supporters header - it should display supporters sponsors] FAILED
    java.lang.AssertionError: Assert failed: The component is not displayed!
        at androidx.compose.ui.test.AssertionsKt.assertIsDisplayed(Assertions.kt:34)
        at io.github.droidkaigi.confsched.testing.robot.SponsorsScreenRobot.checkSponsorItemsDisplayedByRangeAndSponsorType(SponsorsScreenRobot.kt:100)
        at io.github.droidkaigi.confsched.testing.robot.SponsorsScreenRobot.checkDisplaySupportersSponsors(SponsorsScreenRobot.kt:85)
        at io.github.droidkaigi.confsched.sponsors.SponsorsScreenTest$Companion$behaviors$1$1$2$4$2.invokeSuspend$lambda$0(SponsorsScreenTest.kt:75)
        at io.github.droidkaigi.confsched.testing.robot.DefaultCaptureScreenRobot.captureScreenWithChecks(MiniRobots.kt:106)
        at io.github.droidkaigi.confsched.testing.robot.DefaultScreenRobot.captureScreenWithChecks(MiniRobots.kt)

How about adding this to SponsorsScreenRobot and use it? Could you take a look?

fun scrollToBottom() {
        composeTestRule
            .onNode(hasTestTag(SponsorsListLazyVerticalGridTestTag))
            .performScrollToNode(
                hasTestTag(SponsorsListSponsorItemTestTagPrefix.plus(Sponsor.fakes().last().name)),
            )
    }
choi-woo-sung commented 1 week ago

@takahirom Thank you for your help. i fix it.