search

DroidKaigi / conference-app-2024

The Official Conference App for DroidKaigi 2024
Apache License 2.0
458 stars 200 forks source link

After launching the app, the timetable display is distorted for a moment. #955

Open Corvus400 opened 2 months ago

Corvus400 commented 2 months ago

https://github.com/user-attachments/assets/fb9f1c16-240b-45f0-8d96-76f2686e46cf

Corvus400 commented 2 months ago

919

As a test, reverting the above PR change resolved the issue. We are not sure which part of the above PR caused this problem. 🤔

Corvus400 commented 2 months ago

For now, I would like to take charge of this task.🙋‍♂️

takahirom commented 2 months ago

Thanks as always! Assigned 👍

Corvus400 commented 2 months ago

@takahirom CC: @kktaro

919

By the way, if I haven't finished fixing the bug by 9/8, can I revert the above PR?

takahirom commented 2 months ago

Thank you for your suggestion. Yes, of course, we can revert it.

Corvus400 commented 2 months ago

@takahirom Understood. :saluting_face: By the way, is September 8th okay as the deadline? If you want to make it earlier or give up later, I can adjust the date.

takahirom commented 2 months ago

Ideally, I want to release it today. (It heavily depends on my schedule.)

takahirom commented 2 months ago

However, I would like to release one more update, in addition to today's release. I believe this is a critical fix of the information. https://github.com/DroidKaigi/conference-app-2024/pull/981

Corvus400 commented 2 months ago

@takahirom

I want to release it today.

In that case, I think it would be better to issue a PR that reverts the situation immediately. 🏃 This is because, since I discovered this phenomenon, I have been investigating it, but I have no prospects for a solution. 😨

Corvus400 commented 2 months ago

I think this is an emergency, so I'm going to put out a PR to revert now. 🏃

Corvus400 commented 2 months ago

@takahirom I think the issue that will be reopened is not this one, but the following issue. 💁‍♂️ https://github.com/DroidKaigi/conference-app-2024/issues/914

takahirom commented 2 months ago

Thank you for letting me know. I've added text If we merge https://github.com/DroidKaigi/conference-app-2024/pull/919 to issue contetns.

Corvus400 commented 2 months ago

The PR for #919 was reverted in #983, which has caused the problem with #914 to occur again, so we have provided guidance on the problem with #914. Therefore, I thought that #914 also needed to be opened. 🙇