DroidKaigi / conference-app-2024

The Official Conference App for DroidKaigi 2024
Apache License 2.0
458 stars 200 forks source link

Feature/auto scroll to current sesion #972

Closed hiroaki404 closed 2 months ago

hiroaki404 commented 2 months ago

Issue

Overview (Required)

When the screen opens, it scrolls to the item with the current time. The timetablegrid also scrolls.

It does not retain the scroll position when returning from the grid view, but this is an existing issue. I will not take action this time. I wanted to animate the scrolling, but it seemed to cause a nasty bug, so it is out of the scope of this PR.

The work has been made by @yjyoon-dev until the middle of the work. Thanks.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

I have changed the date and time in the system settings.

Before After
github-actions[bot] commented 2 months ago
Snapshot diff report File name Image
KaigiAppTest[KaigiAp
p - when app is star
ting - it should sho
w timetable items]_c
ompare.png
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-13 11
-00 - it should show
an timetable item o
f the current time a
t 11-00]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-12 23
-00 - switch to grid
timetable - it shou
ld not show an indic
ator of the current
time]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-11 10
-00 - switch to grid
timetable - it shou
ld not show an indic
ator of the current
time]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-13 11
-00 - switch to grid
timetable - it shou
ld show an indicator
of the current time
at 11-00]_compare.p
ng
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-12 10
-30 - it should show
an timetable item o
f the current time a
t 10-30]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-12 23
-00 - it should show
an timetable item o
f the current time a
t 23-00]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-12 10
-30 - switch to grid
timetable - it shou
ld show an indicator
of the current time
at 10-30]_compare.p
ng
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-11 10
-00 - it should show
an timetable item o
f the current time a
t 10-00]_compare.png
hiroaki404 commented 2 months ago

Sorry, the test was unexpected on the search screen. I will fix it.

hiroaki404 commented 2 months ago

I used Instant to group the listings. This especially affected the tablet screen. We have restored to grouping using hours and minutes.

takahirom commented 2 months ago

Could you solve the conflict? 🙏

hiroaki404 commented 2 months ago

I noticed when I was merging that it scrolled down even if it wasn't the day of the conference. Please wait a little bit.

hiroaki404 commented 2 months ago

I fix probrem. Please review!

takahirom commented 2 months ago

Looks great! Thank you for your contribution!