DroidKaigi / conference-app-2024

The Official Conference App for DroidKaigi 2024
Apache License 2.0
457 stars 201 forks source link

Refactor TimetableItemTag API to use consistent colors #979

Closed mannodermaus closed 2 months ago

mannodermaus commented 2 months ago

Issue

Overview (Required)

Screenshot (Optional if screenshot test is present or unrelated to UI)

Note the subtle change for the gray tags.

Before After
Incorrect outline color
Before After
Missing icon, incorrect outline color
Before After
Incorrect outline color
Before After
Incorrect outline color
github-actions[bot] commented 2 months ago

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

github-actions[bot] commented 2 months ago
Snapshot diff report File name Image
KaigiAppTest[KaigiAp
p - when app is star
ting - it should sho
w timetable items]_c
ompare.png
FavoritesScreenTest[
FavoritesScreen - wh
en server is operati
onal - setup many fa
vorite sessions - cl
ick first session bo
okmark - it should d
isplay favorite sess
ion without first se
ssion]_compare.png
FavoriteListPreview_
compare.png
FavoritesScreenTest[
FavoritesScreen - wh
en device is tablet
- it should show tim
etable items]_compar
e.png
FavoritesScreenTest[
FavoritesScreen - wh
en server is operati
onal - setup single
favorite session - i
t should display fav
orite session]_compa
re.png
FavoriteSheetPreview
_compare.png
FavoritesScreenTest[
FavoritesScreen - wh
en server is operati
onal - setup many fa
vorite sessions - sc
roll favorites - it
should first session
is not displayed]_c
ompare.png
FavoritesScreenPrevi
ew_compare.png
FavoritesScreenTest[
FavoritesScreen - wh
en server is operati
onal - setup many fa
vorite sessions - it
should display favo
rite session]_compar
e.png
TimetableScreenTest[
TimetableScreen - wh
en server is operati
onal - it should sho
w timetable items]_c
ompare.png
TimetableItemDetailH
eadlinePreview_compa
re.png
TimetableItemDetailS
creenPreview_compare
.png
TimetableItemDetailS
creenTest[TimetableI
temDetailScreen - wh
en server is operati
onal - when font sca
le is small - it sho
uld show small font
session detail]_comp
are.png
TimetableScreenTest[
TimetableScreen - wh
en device is tablet
- it should show tim
etable items]_compar
e.png
TimetableItemDetailH
eadlineWithEnglishPr
eview_compare.png
TimetableItemDetailS
creenTest.runTest[Ti
metableItemDetailScr
een - when server is
operational - when
launch - it should b
e appropriately acce
ssible]_compare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter categor
y chip click - when
click category App A
rchitecture en - it
should selected cate
gory App Architectur
e en]_compare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter day chi
p click - when click
conference day 2 -
it should selected d
ay 2]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en the current date
is 2024-09-12 - it s
hould show timetable
items for Conferenc
eDay1]_compare.png
TimetableItemDetailS
creenTest[TimetableI
temDetailScreen - wh
en server is operati
onal - when launch -
click bookmark - it
should show bookmar
ked session]_compare
.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter categor
y chip click - when
click category Other
en - it should sele
cted category Other
en]_compare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter languag
e chip click - when
click language MIXED
- it should selecte
d language MIXED]_co
mpare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter languag
e chip click - when
click language ENGLI
SH - it should selec
ted language ENGLISH
]_compare.png
TimetableItemDetailS
creenTest[TimetableI
temDetailScreen - wh
en server is operati
onal - when launch -
it should show sess
ion detail title]_co
mpare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
input search word t
o TextField - it sho
uld show search word
and filtered items]
_compare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter categor
y chip click - when
click category Jetpa
ck Compose en - it s
hould selected categ
ory Jetpack Compose
en]_compare.png
TimetableItemDetailH
eadlineWithMixedPrev
iew_compare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter day chi
p click - when click
conference day 1 -
it should selected d
ay 1]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en server is operati
onal - click first s
ession bookmark - it
should show bookmar
ked session]_compare
.png
TimetableItemDetailS
creenTest[TimetableI
temDetailScreen - wh
en server is operati
onal - when launch -
click bookmark - cl
ick bookmark again -
it should show unBo
okmarked session]_co
mpare.png
TimetableScreenTest[
TimetableScreen - wh
en font scale is lar
ge - it should show
title in a single li
ne]_compare.png
SearchScreenTest[Sea
rchScreen - when dev
ice is tablet - inpu
t search word to Tex
tField - it should s
how search word and
filtered items]_comp
are.png
TimetableScreenTest[
TimetableScreen - wh
en server is operati
onal - scroll timeta
ble - it should firs
t session is not dis
played]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en the current date
is 2024-09-11 - it s
hould show timetable
items for Conferenc
eDay1]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en the current date
is 2024-09-13 - it s
hould show timetable
items for Conferenc
eDay2]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en server is operati
onal - click confere
nce day2 tab - it sh
ould change displaye
d day]_compare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter languag
e chip click - when
click language JAPAN
ESE - it should sele
cted language JAPANE
SE]_compare.png