kill switch menu should not always available

DroidPlanner / Tower

Ground Control Station for Android Devices

https://play.google.com/store/apps/details?id=org.droidplanner.android

Other

619 stars 554 forks source link

kill switch menu should not always available #1676

Closed busyStone closed 8 years ago

busyStone commented 8 years ago

kill switch menu should be available only when:

kill switch preference checked
drone support the kill switch feature

m4gr3d commented 8 years ago

@busyStone what's the goal of this pr? The current code is already behaving as described.

busyStone commented 8 years ago

@ne0fhyk

No, if the preference is not checked, the kill switch menu item displayed directly after connect.

The menu item is invisible with default value, but after connect, is set to visible by menu.setGroupVisible. If Kill Switch preference is checked, the value is likely to be set to invisible.

m4gr3d commented 8 years ago

@busyStone you're correct, I missed the issue in my earlier review.