Rssi on top bar

[janky69]

Hi, i have "-" in rssi value in top bar and the speach say "zero" dbm. Its problem only for me? Thank you!

[guiseco]

same to me.

[janky69]

I mean, it was previously value of mavlink radio signal and some bars in phone signal strange style... But i am not sure...

Dne pátek 28. října 2016 Guilherme S. Blanco notifications@github.com napsal(a):

same to me.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DroidPlanner/Tower/issues/1824#issuecomment-256989832, or mute the thread https://github.com/notifications/unsubscribe-auth/AQMV2Zx8qHm6C3DpGxtjShxpyGY_tJQGks5q4jq5gaJpZM4KjmVx .

S přáním všeho dobrého Jiří Janka

[trip5ter]

I have the Same issue, seems to be a problem with Tower 3 and tower 4.0.0 and the latest 4.0.0-beta.9, when i use droid planner 2 RSSI information from the SiK radios is displayed correctly.

Additionally, when I first installed Tower 3 from Google Play Store RSSI information was displayed, it was only after an update of Tower that the rssi was lost....

[mariansoban]

I'm not quite sure, but - couldn't this be the issue? Radio status message is injected to Mavlink communication directly in telemetry radio. Telemetry radios send their system/component ID like: https://github.com/ArduPilot/SiK/blob/master/Firmware/radio/mavlink.c#L47-L49 // use '3D' for 3DRadio #define RADIO_SOURCE_SYSTEM '3' #define RADIO_SOURCE_COMPONENT 'D'

There was a change in Dronekit for Android lib, there are new conditions in GenericMavLinkDrone.onMavLinkMessageReceived() and ArduPilot.onMavLinkMessageReceived(): public void onMavLinkMessageReceived(MAVLinkMessage message) { if (message.sysid != this.getSysid()) { // Reject Messages that are not for the system id

https://github.com/dronekit/dronekit-android/blob/develop/ClientLib/src/main/java/org/droidplanner/services/android/impl/core/drone/autopilot/apm/ArduPilot.java#L389 https://github.com/dronekit/dronekit-android/blob/develop/ClientLib/src/main/java/org/droidplanner/services/android/impl/core/drone/autopilot/generic/GenericMavLinkDrone.java#L578

[guiseco]

I can not test in the simulator (dronekit-sitl). Apparently the simulator does not deliver that data.

[billbonney]

I had the same issue in APM Planner. I can put in. PR to fix.

[mariansoban]

Now I'm convinced, that the issue is the one I wrote before because of this: https://github.com/dronekit/dronekit-android/blob/develop/ClientLib/src/main/java/org/droidplanner/services/android/impl/core/drone/autopilot/generic/GenericMavLinkDrone.java#L240-L243 public short getSysid() { return heartbeat.getSysid(); In other words, system ID to compare is taken from heartbeat packet - this value should be '1', which is system ID of vehicle. Telemetry radio sets system ID to '3' for radio status packet and this packet is later filtered in Tower on those lines in onMavLinkMessageReceived() method.

[guiseco]

Nice catch !

Em 7 de nov de 2016 1:19 PM, "mariansoban" notifications@github.com escreveu:

Now I'm convinced, that the issue is the one I wrote before because of this: https://github.com/dronekit/dronekit-android/blob/develop/ ClientLib/src/main/java/org/droidplanner/services/android/ impl/core/drone/autopilot/generic/GenericMavLinkDrone.java#L240-L243 public short getSysid() { return heartbeat.getSysid(); In other words, component ID to compare is taken from heartbeat packet - this value should be '1', which is component ID of vehicle. Telemetry radio sets component ID to '3' for radio status packet and this packet is later filtered in Tower on those lines in onMavLinkMessageReceived() method.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/DroidPlanner/Tower/issues/1824#issuecomment-258863612, or mute the thread https://github.com/notifications/unsubscribe-auth/AK5WeAqFX44cbotTTUZu5ghRTvZ3dhXaks5q70FrgaJpZM4KjmVx .

[guiseco]

@ne0fhyk Are you alive ?

[m4gr3d]

@guiseco yes :) . I've just been very busy for the past couple months with getting the YouTube VR app out. I'll review the pr that's out to fix the issue.

[m4gr3d]

Closing this issue at it's being addressed in https://github.com/dronekit/dronekit-android/issues/462 by @billbonney.