search

DroidPlanner / Tower

Ground Control Station for Android Devices
https://play.google.com/store/apps/details?id=org.droidplanner.android
Other
622 stars 554 forks source link

Auto Mission Assistant #754

Closed arthurbenemann closed 9 years ago

arthurbenemann commented 10 years ago

The mode detail fragment for auto missions should aid the user during an auto missiom. Some of the possible features are:

m4gr3d commented 10 years ago

@arthurbenemann is it possible to have Jason come up with a design for the mission assistant. Having a clear goal/ui target will help spread and speed up the development.

arthurbenemann commented 10 years ago

Certainly, I`ll discuss it with him Monday.

2014-05-10 10:40 GMT-07:00 Fredia Huya-Kouadio notifications@github.com:

@arthurbenemann https://github.com/arthurbenemann is it possible to have Jason come up with a design for the mission assistant. Having a clear goal/ui target will help spread and speed up the development.

— Reply to this email directly or view it on GitHubhttps://github.com/DroidPlanner/droidplanner/issues/754#issuecomment-42748841 .

Arthur Benemann

azrin1972 commented 10 years ago

I'm currently trying to built the same thing. I'll wait for the discussion outcome.

Azrin Aris

On 11/05/2014, at 2:10, Arthur Benemann notifications@github.com wrote:

Certainly, I`ll discuss it with him Monday.

2014-05-10 10:40 GMT-07:00 Fredia Huya-Kouadio notifications@github.com:

@arthurbenemann https://github.com/arthurbenemann is it possible to have Jason come up with a design for the mission assistant. Having a clear goal/ui target will help spread and speed up the development.

— Reply to this email directly or view it on GitHubhttps://github.com/DroidPlanner/droidplanner/issues/754#issuecomment-42748841 .

Arthur Benemann — Reply to this email directly or view it on GitHub.

jason4short commented 10 years ago

Here you go!

auto_mode-control

m4gr3d commented 10 years ago

@jason4short @arthurbenemann looks good, although how do we get about estimating the mission remaining time. That would be highly dependent on the type of waypoint, their duration time (if applicable) as well as the drone's speed.

Also, does 'rewind' means return to the previous waypoint, and 'advance' means skip the upcoming waypoint?

arthurbenemann commented 10 years ago

@ne0fhyk Rewind means setCurrentWp(drone.getCurrentWP()-1), forward means setCurrentWp(drone.getCurrentWP()+1)

jason4short commented 10 years ago

I have no idea about the mission time. It was Arthur's suggestion!

bbasso commented 10 years ago

I think the idea was to just look at the WPNAV_SPEED and the remaining distance, since changing speed during a mission is not something done that often. Also, I like the idea of progress bars, especially if the completion time is just an estimate. People are used to seeing progress bars for installing software and such, and those hang all the time--I think it would help drive home the point that it's just an estimate.

jason4short commented 10 years ago

I added WP speed to the panel. I've always wanted to control this during flight. Also added restart.

mission_control

bbasso commented 10 years ago

Does change the speed for just that waypoint or all waypoints? I like the idea of being able to change the speed for the whole mission, but dont see a huge need for individual waypoints. We shoudl be careful to not add too many options for each mission item. For example, the WP delay parameter--we may use it a fair amount, but do other people? I think it's pretty fringe.

arthurbenemann commented 10 years ago

@bbasso This side panel is for flight mode details, in this case for the auto mode mission.

Changes like speed would be global.

azrin1972 commented 10 years ago

Having options is good but I agree with you that too many options might just be confusing for users.

I personally like to have individual delay and speed. What I would like to suggest is to have a check box 'advance parameter' that when checked will reveal the extra settings for each WP.

I can start looking into that if everyone agreed to it.

Just an idea though...

Azrin Aris

On 10/06/2014, at 6:47, Brandon Basso notifications@github.com wrote:

Does change the speed for just that waypoint or all waypoints? I like the idea of being able to change the speed for the whole mission, but dont see a huge need for individual waypoints. We shoudl be careful to not add too many options for each mission item. For example, the WP delay parameter--we may use it a fair amount, but do other people? I think it's pretty fringe.

Brandon Basso, PhD :: Senior Research and Development Engineer :: 3D Robotics :: Berkeley, CA

On Mon, Jun 9, 2014 at 4:50 PM, jason4short notifications@github.com wrote:

I added WP speed to the panel. I've always wanted to control this during flight. Also added restart.

[image: mission_control] https://cloud.githubusercontent.com/assets/3344856/3222548/b1094356-f017-11e3-8a43-e41d9a5e5312.png

Reply to this email directly or view it on GitHub https://github.com/DroidPlanner/droidplanner/issues/754#issuecomment-45542376 .

— Reply to this email directly or view it on GitHub.

bbasso commented 10 years ago

@azrin1972, I like the idea of an Advanced check box which reveals options like speed and delay. My sense from watching users fly our copters is that many people do not have need for a WP delay, which is something that should be more part of a mission script than a native basic mission behavior. Just a guess at what would be useful/interesting for most users:

-mission-wide speed control, changeable in real time -mission-wide yaw behavior, changeable in real time -WP navigation: spline, etc

So essentially, just mission wide parameters.

azrin1972 commented 10 years ago

Ok will look in to it. A lot of code has change... I'm starting all over again :)

Azrin Aris

On 10/06/2014, at 10:09, Brandon Basso notifications@github.com wrote:

@azrin1972, I like the idea of an Advanced check box which reveals options like speed and delay. My sense from watching users fly our copters is that many people do not have need for a WP delay, which is something that should be more part of a mission script than a native basic mission behavior. Just a guess at what would be useful/interesting for most users:

-mission-wide speed control, changeable in real time -mission-wide yaw behavior, changeable in real time -WP navigation: spline, etc

So essentially, just mission wide parameters.

— Reply to this email directly or view it on GitHub.

m4gr3d commented 10 years ago
codyfinn commented 9 years ago

In my team's experience we found if useful to check the mission for a takeoff, and landing waypoint before takeoff. Would something like this be a useful addition to the assistant? I have some ideas on how to implement it in way that I think would make it simple.

m4gr3d commented 9 years ago

We already have an option to automatically insert takeoff and land/rtl waypoint if missing before sending the mission to the drone. On Nov 12, 2014 8:26 PM, "Cody Finn" notifications@github.com wrote:

In my team's experience we found if useful to check the mission for a takeoff, and landing waypoint before takeoff. Would something like this be a useful addition to the assistant? I have some ideas on how to implement it in way that I think would make it simple.

— Reply to this email directly or view it on GitHub https://github.com/DroidPlanner/droidplanner/issues/754#issuecomment-62840146 .

m4gr3d commented 9 years ago

Fixed by pr #1538